fix: remove redundant minimum payable amount from Sell Appliance modal#1373
Open
Zhey-on wants to merge 1 commit intoEnAccess:mainfrom
Open
fix: remove redundant minimum payable amount from Sell Appliance modal#1373Zhey-on wants to merge 1 commit intoEnAccess:mainfrom
Zhey-on wants to merge 1 commit intoEnAccess:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the read-only Minimum Payable Amount field from the cost-based Sell Appliance modal.
Why this should be removed
I traced the field through the current modal, the deferred-payment flow, and the backend payment validation.
In the active Sell Appliance modal, Minimum Payable Amount is not a separate input and it does not represent a second business rule. It is derived directly from the installment amount the user already entered.
On the backend, the real minimum accepted payment for this flow already comes from the installment schedule itself: deferred appliance payments are rejected when the payment amount is below one installment. Because of that, showing both Rate Cost and Minimum Payable Amount in this modal makes the UI look like there are two different values to configure, when in practice there is only one.
That extra field adds noise, creates avoidable confusion, and does not help the operator make a better decision.
What changed
Scope
I kept this PR intentionally narrow.
I did not touch the older SellApplianceCard flow in this change. That legacy SHS and tariff path still uses the same concept historically when creating a tariff, and folding that into this PR would make the review less clear.
Validation